Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 18 Support #5639

Closed
ghost opened this issue Oct 25, 2022 · 7 comments · Fixed by #5656
Closed

Node.js 18 Support #5639

ghost opened this issue Oct 25, 2022 · 7 comments · Fixed by #5656
Labels
accepted The feature request is considered. If nobody works actively on it, feel free to.

Comments

@ghost
Copy link

ghost commented Oct 25, 2022

Question 💬

Node.js 18 LTS is starting, but this repository restricts the use of Node.18 in the engine in package.json.
Bugs for Node.js 18 seem to be all closed, is there anything blocking support?

I opened a discussion before, but now that LTS has started, I'll post it here as well.
#5329

How to reproduce ☕️


Contributing 🙌🏽

Yes, I am willing to help answer this question in a PR

@ghost ghost added the question Ask how to do something or how something works label Oct 25, 2022
@ghost
Copy link
Author

ghost commented Oct 25, 2022

Reference: Node.js Release Schedule
https://github.com/nodejs/release#release-schedule

@panva
Copy link
Contributor

panva commented Oct 25, 2022

v18.12.0 has not yet been released (as of 8:20 UTC) so technically this

now that LTS has started

is not true for the next couple hours and for all previously released v18.x versions.

@ThangHuuVu
Copy link
Member

Let's keep this open to keep track of adding Node v18 to the engine compatibility list 👀

@ThangHuuVu ThangHuuVu added accepted The feature request is considered. If nobody works actively on it, feel free to. and removed question Ask how to do something or how something works labels Oct 25, 2022
@ryanelian
Copy link

ryanelian commented Oct 25, 2022

+1 to this and at the same time, allowing next-auth to be installed with the just-released Next.js 13

Right now next-auth cannot be installed with Next.js 13 using npm due to peerDependencies throwing errors.

@ghost
Copy link
Author

ghost commented Oct 26, 2022

Sorry for false start.
Thanks!

@daniharo
Copy link

daniharo commented Nov 24, 2022

next-auth won't work in Node 18 until openid-client dependency is updated to a new version which includes this commit: panva/node-openid-client@9aefba3.

Current version 5.1.6 gives this error:

openid-client@5.1.6: The engine "node" is incompatible with this module. Expected version "^12.19.0 || ^14.15.0 || ^16.13.0". Got "18.12.1"

Temporary solution is to use --ignore-engines when installing packages.

@nfts2me
Copy link

nfts2me commented Mar 7, 2023

At least on Vercel using Node 18.x makes NetxAuth behave differently from 16.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The feature request is considered. If nobody works actively on it, feel free to.
Projects
None yet
5 participants