fix: Move fonts to css/fonts and fix css path resolving
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/css-assets-loading
branch
from
74e5896
to
177ef1b
Compare
|
Where do we import fonts? |
An example is the viewer app where we import roboto for CI tests |
|
But same with images e.g. if you have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you import e.g. fonts in your scss like
url(some/font.woff)the woff needs to be placed correctly, and especially the path needs to be set.CSS does not allow dynamic URLs so we can not use our
OC.filepathfunction but need to return a relative path to the CSS file that loaded the woff.