feat: Add CSSEntryPointsPlugin to fix vite for creating one CSS entry per JS entry point
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
susnux
force-pushed
the
feat/CSSEntryPointsPlugin
branch
from
dc30369
to
eca5077
Compare
susnux
added
bug
susnux
force-pushed
the
feat/CSSEntryPointsPlugin
branch
from
eca5077
to
f869268
Compare
ShGKme
reviewed
Jun 20, 2024
ShGKme
reviewed
Jun 20, 2024
34 tasks
…ry per JS entry point with `cssCodeSplit` vite only inlines CSS in async chunks, but it does not properly create CSS files for synchronously imported CSS. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…Split` is set Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/CSSEntryPointsPlugin
branch
from
1ddbbed
to
716612e
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
|
/backport to stable1 |
ShGKme
approved these changes
Jun 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
cssCodeSplitvite only inlines CSS in async chunks, but it does not properly create CSS files for synchronously imported CSS.TODO: * Create also CSS entries if there are no styles imported? Pro: Empty CSS is cachable and today there might be no styles but tomorrow there might be some -> make devs lives easier.(implemented)