Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify an output prefix and load app id from appinfo #207

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Allow to specify an output prefix and load app id from appinfo #207

merged 2 commits into from
Jun 20, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 20, 2024

  1. Allow to set a custom prefix for assets instead of forcing appName-
  2. Load app id from appinfo if possible

@susnux
feat(app-config): Allow to specify assets prefix
eb4410c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(app-config): Load app id from appinfo if possible
f8357a5 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added enhancement New feature or request 3. to review Ready to review labels Jun 20, 2024
@susnux susnux requested a review from ShGKme June 20, 2024 12:34
@susnux
Copy link
Contributor Author

susnux commented Jun 20, 2024

/backport to stable1

@ShGKme ShGKme mentioned this pull request Jun 20, 2024
Draft
34 tasks
@susnux susnux merged commit 50d8324 into main Jun 20, 2024
12 checks passed
@susnux susnux deleted the feat/prefix branch June 20, 2024 22:46
@backportbot backportbot bot mentioned this pull request Jun 20, 2024
Merged
@susnux susnux mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees
No one assigned
Labels
3. to review Ready to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @ShGKme