Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appconfig): cssCodeSplit is enabled by default so handle CSS entries #243

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix(appconfig): cssCodeSplit is enabled by default so handle CSS entries #243

merged 1 commit into from
Jul 12, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 12, 2024

If no CSS inline always add the CSS entry point plugin if not explicitly disabled cssCodeSplit.

@susnux susnux added bug Something isn't working 3. to review Ready to review labels Jul 12, 2024
@susnux susnux requested review from ShGKme and Antreesy July 12, 2024 14:16
@susnux
Copy link
Contributor Author

susnux commented Jul 12, 2024

/backport to stable1

@susnux
fix(appconfig): cssCodeSplit is enabled by default so handle CSS en…
2e36500 
…tries

If no CSS inline always add the CSS entry point plugin if not explicitly disabled `cssCodeSplit`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/css-code-split-is-enabled-by-default branch from 5051190 to 2e36500 Compare July 12, 2024 14:16
Antreesy
Antreesy approved these changes Jul 12, 2024
View reviewed changes
Copy link

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭
Worth noting it in the readme / release description?

@susnux
Copy link
Contributor Author

susnux commented Jul 12, 2024

/backport to stable1

@susnux susnux merged commit 77b9409 into main Jul 12, 2024
11 checks passed
@susnux susnux deleted the fix/css-code-split-is-enabled-by-default branch July 12, 2024 15:00
@backportbot backportbot bot mentioned this pull request Jul 12, 2024
Merged
@susnux susnux mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Ready to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS code splitting works now, but not as documented
2 participants
@susnux @Antreesy