fix: Remove define of process.env from base config
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
===========================================
+ Coverage 54.73% 80.22% +25.49%
===========================================
Files 7 8 +1
Lines 539 536 -3
Branches 22 32 +10
===========================================
+ Hits 295 430 +135
+ Misses 222 74 -148
- Partials 22 32 +10
|
susnux
force-pushed
the
fix/remove-process-env-defines
branch
from
1d4e208
to
fed0253
Compare
Removing `process.env` is only required for apps, as we now build apps not in lib mode it is removed automatically by vite Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/remove-process-env-defines
branch
from
fed0253
to
55de856
Compare
skjnldsv
approved these changes
Oct 4, 2023
raimund-schluessler
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
process.envis only required for apps, as we now build apps not in lib mode it is removed automatically by vite.Fixes testing issues when using vitest.