Skip to content

Commit

Permalink
fix(NcActions): Role menu needs a label assigned so label by trigger
Browse files Browse the repository at this point in the history
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
susnux committed Aug 29, 2024
1 parent 749fcaf commit 5cf16e5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/components/NcActions/NcActions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -1779,8 +1779,9 @@ export default {
tabindex: '-1',
ref: 'menuList',
role: this.config.popupRole,
// Dialog must have a label
'aria-labelledby': this.actionsMenuSemanticType === 'dialog' ? triggerRandomId : undefined,
// For most roles a label is required (dialog, menu), but also in general nothing speaks against labelling a list.
// It is even recommended to do so.
'aria-labelledby': triggerRandomId,
'aria-modal': this.actionsMenuSemanticType === 'dialog' ? 'true' : undefined,
}, [
actions,
Expand Down

0 comments on commit 5cf16e5

Please sign in to comment.