Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcVNodes): add re-export in root export and add docs #5664

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix(NcVNodes): add re-export in root export and add docs #5664

merged 2 commits into from
Jun 4, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 4, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

A util component to render a VNode or an array of VNodes from the prop or the default slot.

@ShGKme
chore(NcVNodes): add docs
f0145a2 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review Waiting for reviews feature: documentation Related to the documentation labels Jun 4, 2024
@ShGKme ShGKme self-assigned this Jun 4, 2024
@ShGKme ShGKme mentioned this pull request Jun 4, 2024
Open
@raimund-schluessler
Copy link
Contributor

Why not. Although we don't even export it in https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/src/components/index.js

@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 4, 2024

we don't even export

Oh... 🥲

@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 4, 2024

Although we don't even export it in

Fixed here as well.

In general component has been exported in /dist/Components.

@ShGKme ShGKme changed the title chore(NcVNodes): add docs chore(NcVNodes): add docs and export in root re-export Jun 4, 2024
@ShGKme
fix(NcVNodes): add missing export in root
628bd0a 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 4, 2024

Commit renamed to fix with a new export.

@ShGKme ShGKme changed the title chore(NcVNodes): add docs and export in root re-export fix(NcVNodes): add re-export in root export and add docs Jun 4, 2024
@ShGKme ShGKme added the bug Something isn't working label Jun 4, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 4, 2024

/backport to next

@ShGKme ShGKme added this to the 8.12.1 milestone Jun 4, 2024
@ShGKme ShGKme enabled auto-merge June 4, 2024 17:21
@ShGKme ShGKme merged commit 66ef3fe into master Jun 4, 2024
17 checks passed
@ShGKme ShGKme deleted the docs/NcVNodes branch June 4, 2024 17:22
@backportbot backportbot bot mentioned this pull request Jun 4, 2024
Merged
2 tasks
@susnux susnux mentioned this pull request Jun 20, 2024
Merged
1 task
@Antreesy Antreesy modified the milestones: 8.12.1, 8.13.0 Jun 25, 2024
@susnux susnux mentioned this pull request Jul 3, 2024
Closed
4 tasks
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: documentation Related to the documentation
Projects
None yet
Milestone
8.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @raimund-schluessler @susnux @Antreesy