Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcAppSidebar): add toggleAttrs prop to pass attributes on the toggle button #5695

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 12, 2024

☑️ Resolves

  • In Talk when we are in the call, we need the top bar to be dark-themed.
    In the past, we had a custom toggle button in the top bar with data-dark-theme on the top bar to archive that. Now with the built-in toggle button, it is not possible...
  • Add toggleAttrs similar to toggleClasses prop to pass attributes on the toggle button
    • Allows to set data-them-dark manually from Talk
  • Alternative:
    1. Add hideToggle prop to hide the default toggle button
    2. Add NcAppToggleButton to allow users to place it anywhere
    3. Connect this NcAppToggleButton with NcAppSidebar inside @nextcloud/vue
    4. Do not forget about slide animations for the custom toggle button

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Add toggleAttrs

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Jun 12, 2024
@ShGKme ShGKme added this to the 8.13.0 milestone Jun 12, 2024
@ShGKme ShGKme self-assigned this Jun 12, 2024
@susnux
Copy link
Contributor

susnux commented Jun 12, 2024

Thank you!

@ShGKme ShGKme merged commit 42ad156 into master Jun 13, 2024
18 checks passed
@ShGKme ShGKme deleted the feat/NcAppSidebar--toggleAttrs branch June 13, 2024 12:00
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 13, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants