Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigationSettings): border radius of toggle button #5765

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix(NcAppNavigationSettings): border radius of toggle button #5765

merged 1 commit into from
Jul 9, 2024

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Jul 3, 2024 •
edited by susnux
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20240703_095147 grafik

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@st3iny st3iny self-assigned this Jul 3, 2024
@st3iny st3iny mentioned this pull request Jul 3, 2024
Closed
@st3iny
fix(NcAppNavigationSettings): border radius of toggle button
8c75d88 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/NcAppNavigationSettings/toggle-border-radius branch from bf9c8a8 to 8c75d88 Compare July 8, 2024 08:50
@st3iny st3iny added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component design Design, UX, interface and interaction design labels Jul 8, 2024
@st3iny st3iny marked this pull request as ready for review July 8, 2024 08:53
@susnux
Copy link
Contributor

susnux commented Jul 8, 2024

/backport to next

@susnux susnux added this to the 8.14.1 milestone Jul 8, 2024
@susnux susnux merged commit fb5a532 into master Jul 9, 2024
20 checks passed
@susnux susnux deleted the fix/NcAppNavigationSettings/toggle-border-radius branch July 9, 2024 13:47
@backportbot backportbot bot mentioned this pull request Jul 9, 2024
Merged
@Antreesy Antreesy mentioned this pull request Jul 22, 2024
Merged
@susnux susnux modified the milestones: 8.14.1, 8.15.0 Jul 22, 2024
This was referenced Aug 14, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 26, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
8.15.0
Development

Successfully merging this pull request may close these issues.

NcAppNavigationSettings: Settings toggle button stil has --pill border radius
3 participants
@st3iny @susnux @Pytal