feat(NcButton): Add size prop to allow setting the button size to small, normal, large
#5767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
susnux
requested review from
raimund-schluessler,
marcoambrosini,
DorraJaouad and
Antreesy
|
/backport to next |
…small`, `normal`, `large` With our new 3 different clickable area sizes we have some places, like the header menu, where we still want to use "large" buttons. So this gives the ability to set the button size to either `normal` which is the default, `large` for main actions or `small`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
marcoambrosini
approved these changes
Jul 3, 2024
Merged
2 tasks
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
With our new 3 different clickable area sizes we have some places, like the header menu, where we still want to use "large" buttons. So this gives the ability to set the button size to either
normalwhich is the default,largefor main actions orsmall.🖼️ Screenshots
Bildschirmaufnahme_20240703_133223.webm
🏁 Checklist
nextrequested with a Vue 3 upgrade