Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(NcAppNavigationCaption): remove margin-bottom #5815

Merged
merged 1 commit into from
Jul 18, 2024
Merged

style(NcAppNavigationCaption): remove margin-bottom #5815

merged 1 commit into from
Jul 18, 2024

Conversation

GVodyanov
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Jul 17, 2024
@GVodyanov GVodyanov self-assigned this Jul 17, 2024
@GVodyanov GVodyanov mentioned this pull request Jul 17, 2024
Merged
@GVodyanov GVodyanov requested a review from susnux July 18, 2024 08:37
@GVodyanov
Copy link
Contributor Author

image

Now we have this with margin-bottom: var(--default-grid-baseline);

st3iny
st3iny approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please squash your commits.

@GVodyanov
style(NcAppNavigationCaption): remove margin-bottom
2e63008 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the style/remove-caption-margin-bottom branch from 1cde7f8 to 2e63008 Compare July 18, 2024 12:06
@GVodyanov GVodyanov enabled auto-merge July 18, 2024 12:06
@GVodyanov GVodyanov merged commit ad3a9c8 into master Jul 18, 2024
19 checks passed
@GVodyanov GVodyanov deleted the style/remove-caption-margin-bottom branch July 18, 2024 12:08
@susnux
Copy link
Contributor

susnux commented Jul 18, 2024

/backport to next

@susnux susnux added the bug Something isn't working label Jul 18, 2024
@backportbot backportbot bot mentioned this pull request Jul 18, 2024
Merged
@susnux
Copy link
Contributor

susnux commented Jul 18, 2024

Please always backport to next (there is a todo list in the PR template ;) ) and assign correct labels (bug, enhancement etc) for changelog generation :)

@Antreesy Antreesy mentioned this pull request Jul 22, 2024
Merged
This was referenced Aug 14, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 26, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@susnux susnux Awaiting requested review from susnux

Assignees

@GVodyanov GVodyanov

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spacing issues in app navigation
4 participants
@GVodyanov @susnux @st3iny @marcoambrosini