Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): Adjust icon color when the list item is active #5936

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix(NcListItem): Adjust icon color when the list item is active #5936

merged 1 commit into from
Aug 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 6, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2024-08-06 at 22-45-48 Nextcloud Vue Style Guide image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux
fix(NcListItem): Adjust icon color when the list item is active
2516ea9 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: list-item Related to the list-item component labels Aug 6, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 6, 2024

/backport to next

@susnux susnux merged commit 7b6f86a into master Aug 8, 2024
19 checks passed
@susnux susnux deleted the fix/list-item-color branch August 8, 2024 11:03
@backportbot backportbot bot mentioned this pull request Aug 8, 2024
Merged
@susnux susnux mentioned this pull request Aug 20, 2024
Merged
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@ShGKme ShGKme ShGKme approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: list-item Related to the list-item component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon color in navigation differs from text color
4 participants
@susnux @GretaD @ShGKme @marcoambrosini