[next] feat(NcCounterBubble): add count prop for humanized count display #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
requested review from
Antreesy,
jancborchardt,
susnux and
ShGKme
backportbot
bot
added
enhancement
ShGKme
force-pushed
the
backport/5863/next
branch
from
dcf5d7a
to
3e53785
Compare
|
Don't forget to include #5985 =) |
I won't include, it's a different PR ._. |
ShGKme
force-pushed
the
backport/5863/next
branch
from
3e53785
to
dec1dd4
Compare
ShGKme
added
breaking
susnux
reviewed
Aug 20, 2024
| */ | ||
| raw: { | ||
| type: Boolean, | ||
| required: false, |
There was a problem hiding this comment.
All props are optional by default, unless
required: trueis specified.
susnux
approved these changes
Aug 20, 2024
then do not forget to backport ;) |
I won't. One by one. That PR is on made on top of this |
|
Hmm, It also make sense to not mix new huge change (removing API) to a backport |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
backport/5863/next
branch
from
dec1dd4
to
c6d9c5b
Compare
|
Kept backport clean with the backport only |
ShGKme
approved these changes
Aug 20, 2024
ShGKme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #5863