Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAvatar): math-perfect adaptive scaling #6004

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 21, 2024

Resolves

Diagram

image

$$\sqrt2 r_1 = r_1 + y$$

$$\implies y = r_1(\sqrt2 - 1)$$

$$\sqrt2 (r_2 + x) = y$$

$$\sqrt2 (r_2 + x) = r_1(\sqrt2 - 1)$$

$$\implies x = r_1(1 - \frac {1} {\sqrt(2)}) - r_2$$

🖼️ Screenshots

🏚️ Before 🏡 After
avatar-before avatar-after

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 2. developing Work in progress feature: avatar Related to the avatar component labels Aug 21, 2024
@ShGKme ShGKme added this to the 8.17.1 milestone Aug 21, 2024
@ShGKme ShGKme self-assigned this Aug 21, 2024
@susnux susnux modified the milestones: 8.17.1, 8.18.0 Aug 30, 2024
@Antreesy Antreesy modified the milestones: 8.18.0, 8.18.1 Sep 12, 2024
@susnux susnux modified the milestones: 8.18.1, 8.19.0, 8.20.0, 8.19.1 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants