Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] feat(NcDialogButton): Allow to return false from callback to keep dialog open #6035

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from
Draft

[next] feat(NcDialogButton): Allow to return false from callback to keep dialog open #6035

wants to merge 2 commits into from

Commits on Aug 31, 2024

  1. feat(NcDialogButton): Allow to return false from callback to keep d… 

    …ialog open

If the callback returns `false` then the click event will not be forwarded.
This could be usful if the click triggers a validation that fails and the user
should be able to fix the issue.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux @ShGKme @backportbot
    2 people authored and backportbot[bot] committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    be4453b View commit details
    Browse the repository at this point in the history

  2. chore: fix ESLint issues 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux @backportbot
    susnux authored and backportbot[bot] committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    78a42a1 View commit details
    Browse the repository at this point in the history