Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcEmojiPicker): adjust hover effects to new design #6056

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix(NcEmojiPicker): adjust hover effects to new design #6056

merged 1 commit into from
Sep 6, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 5, 2024

☑️ Resolves

  • Fix hover effects on emoji buttons
  • Added fallback for Nextcloud <= v29

🖼️ Screenshots

🏚️ Before 🏡 After
2024-09-05_19h18_50 2024-09-05_19h18_24

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcEmojiPicker): adjust hover effects to new design
6253ff5 
Signed-off-by: Antreesy <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: emoji picker Related to the emoji picker component labels Sep 5, 2024
@Antreesy Antreesy added this to the 8.18.0 milestone Sep 5, 2024
@Antreesy Antreesy self-assigned this Sep 5, 2024
@susnux
Copy link
Contributor

susnux commented Sep 5, 2024 •
edited
Loading

I am not sure but was there not a design review call where it was said that round outline makes sense for emoji?

(Changes look good, just want to make sure this is what designer intended)

@ShGKme
Copy link
Contributor

ShGKme commented Sep 5, 2024

I'd keep it rounded

@marcoambrosini
Copy link
Contributor

@susnux @ShGKme I think they look fine less rounded, like the reaction buttons in talk right now

susnux
susnux approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do not care, both are fine. Noticed that e.g. messengers like Telegram also have "angular" hover effect.
Changes are clean 👍

(To cite a user I asked: "IPhone users would prefer the round one, Android users the angular one.")

@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 6, 2024

/backport to next

@Antreesy Antreesy merged commit c35edb8 into master Sep 6, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/noid/emoji-picker-border-radius branch September 6, 2024 10:14
@backportbot backportbot bot mentioned this pull request Sep 6, 2024
Merged
This was referenced Sep 12, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: emoji picker Related to the emoji picker component
Projects
None yet
Milestone
8.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @susnux @ShGKme @marcoambrosini