Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcListItem): change condition to display the counter number #6117

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

julien-nc
Copy link
Contributor

The previous condition was always showing the counter number because the counter-number prop has 0 as default value.

This can be seen in a few examples in https://next--nextcloud-vue-components.netlify.app/#/Components/NcListItems?id=nclistitem

image

<NcListItem compact
	name="Name of the element">
	<template #icon>
		<IconNoteText :size="20" />
	</template>
</NcListItem>

…ding to the doc, previous condition was always showing it

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added bug Something isn't working 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Sep 23, 2024
@julien-nc julien-nc added this to the 9.0.0-alpha.6 milestone Sep 23, 2024
@julien-nc julien-nc merged commit ac728da into next Sep 26, 2024
20 checks passed
@julien-nc julien-nc deleted the fix/noid/nc-list-item-count-number branch September 26, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: list-item Related to the list-item component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants