Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon color in navigation differs from text color #2240

Closed
AndyScherzinger opened this issue Jul 8, 2024 · 2 comments · Fixed by nextcloud-libraries/nextcloud-vue#5936
Closed
Assignees
Labels
bug Something isn't working pending fix Waiting for a fix on one of our dependencies

Comments

@AndyScherzinger
Copy link
Member

Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug
2024-07-08 20_11_18-Daily Form - Forms - Nextcloud Daily – Mozilla Firefox

Icon is black, text is white

To Reproduce
Steps to reproduce the behavior:

  1. master-server and master-forms
  2. OS is dark mode, Nc is light mode

Expected behavior
same color for both

Screenshots
see above

Nextcloud (please complete the following information):

  • Nextcloud-Version: 30-master

  • Forms-Version: master
    Desktop (please complete the following information):

  • OS: [e.g. iOS]

  • Browser [e.g. chrome, safari]

  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Browser log

Open your console, reload your page and/or do the action leading to this issue and copy/paste the log in this thread.
How to access your browser console (Click to expand)

Chrome

  • Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
  • Alternative method:
    1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
    2. Click the “console” tab.

Safari

  • Press CMD + ALT + I to open the Web Inspector.
  • See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

IE9

  1. Press F12 to open the developer tools.
  2. Click the “console” tab.

Firefox

  • Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
  • or, if Firebug is installed (recommended):
    1. Press F12 to open Firebug.
    2. Click on the “console” tab.

Opera

  1. Press CTRL + SHIFT + I to open Dragonfly.
  2. Click on the “console” tab.

Additional context
Add any other context about the problem here.

@AndyScherzinger AndyScherzinger added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. papercut Annoying recurring issue with possibly simple fix. labels Jul 8, 2024
@Chartman123 Chartman123 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jul 8, 2024
@Chartman123
Copy link
Collaborator

@AndyScherzinger Is it possible that this is a bug in NcListItem? We're using currentColor for filling the SVG in FormsAppNavigation

@AndyScherzinger
Copy link
Member Author

I don't know or rater lack the deeper technical knowledge. Maybe you do @susnux?

@jancborchardt jancborchardt changed the title Icon color in sidebar differs from text color Icon color in navigation differs from text color Jul 9, 2024
@susnux susnux self-assigned this Aug 7, 2024
@Chartman123 Chartman123 added pending fix Waiting for a fix on one of our dependencies and removed 1. to develop Accepted and waiting to be taken care of papercut Annoying recurring issue with possibly simple fix. labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending fix Waiting for a fix on one of our dependencies
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants