feat: Ask for restarting submission if form was changed #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koc
commented
Sep 11, 2024
Chartman123
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Hi @Koc
nice work. A few wordings changed :) Not tested yet, will do this this evening :)
Chartman123
added
enhancement
Koc
force-pushed
the
feature/restart-form-submission-on-change
branch
3 times, most recently
from
dceffce
to
ffc0ad6
Compare
|
🗒️ Changes:
cc @Chartman123 |
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/restart-form-submission-on-change
branch
from
ffc0ad6
to
dd9fc3a
Compare
Chartman123
reviewed
Sep 23, 2024
| <template #icon> | ||
| <NcIconSvgWrapper :svg="IconRefreshSvg" /> | ||
| </template> | ||
| {{ t('forms', 'Restart submission') }} |
There was a problem hiding this comment.
We should use the "clear form" string here as well to be more consistent.
Suggested change
| {{ t('forms', 'Restart submission') }} | |
| {{ t('forms', 'Clear form') }} |
Comment on lines
+465
to
+469
| { | ||
| label: t('forms', 'Abort'), | ||
| icon: IconCancelSvg, | ||
| callback: () => {}, | ||
| }, |
There was a problem hiding this comment.
I think tertiary is enough here.
Suggested change
| { | |
| label: t('forms', 'Abort'), | |
| icon: IconCancelSvg, | |
| callback: () => {}, | |
| }, | |
| { | |
| label: t('forms', 'Abort'), | |
| icon: IconCancelSvg, | |
| type: tertiary, | |
| callback: () => {}, | |
| }, |
Chartman123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #2312 based on a comment #2312 (comment)
nextcloud-reset-demo-2024-09-23_01.49.44.mp4
🎁 Bonus
Added reset button