Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS tests failing on CI #4487

Closed
LukasReschke opened this issue Apr 25, 2017 · 6 comments · Fixed by #4494
Closed

JS tests failing on CI #4487

LukasReschke opened this issue Apr 25, 2017 · 6 comments · Fixed by #4494
Labels
bug high
Milestone
Nextcloud 12.0

Comments

@LukasReschke
Copy link
Member

Seems related to karma-runner/karma-phantomjs-launcher#126
@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone Apr 25, 2017
@LukasReschke LukasReschke changed the title JS tests failing on cI JS tests failing on CI Apr 25, 2017
@LukasReschke
Copy link
Member Author

Let's just migrate away from the PhantomJS launcher and switch to headless Chrome instead: karma-runner/karma-chrome-launcher#111

@ChristophWurst
Copy link
Member

Ouch. This is bad. Headless Chrome doesn't qualify for a short-term solution as that PR has not been merged.

@ChristophWurst
Copy link
Member

cc @nextcloud/javascript

@LukasReschke
Copy link
Member Author

@MorrisJobke mentioned that pinning Karma 1.5.x might make sense as a temporary workaround.

@MorrisJobke
Copy link
Member

I thought it is because the dependencies has changed, so I looked it up and this is the diff between working and not working:

bildschirmfoto 2017-04-25 um 10 19 04

That means we should check if pinning jasmine-core helps.

@MorrisJobke MorrisJobke mentioned this issue Apr 25, 2017
Merged
@MorrisJobke
Copy link
Member

"Fix" is in #4494

Nevertheless we should migrate to the other launcher if this is the only option. 🙈

@MorrisJobke MorrisJobke mentioned this issue Apr 25, 2017
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Aug 13, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Sep 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging a pull request may close this issue.

Fix JS unit failure because of Jasmine 2.6 and the phantomjs launcher nextcloud/server
3 participants
@MorrisJobke @LukasReschke @ChristophWurst