Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show out of office replacement #12510

Merged
merged 1 commit into from
Jul 2, 2024
Merged

feat: show out of office replacement #12510

merged 1 commit into from
Jul 2, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jun 13, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good! Let's wait for server PR to be merged, then we'll test it again
When possible, please provide a screenshot, if design team would like to check it out

src/components/NewMessage/NewMessageAbsenceInfo.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessageAbsenceInfo.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessageAbsenceInfo.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise. However, the UI doesn't look much accessible cc @nextcloud/designers

image

image

src/components/NewMessage/NewMessageAbsenceInfo.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessageAbsenceInfo.vue Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

@DorraJaouad @Antreesy please review

@hamza221 hamza221 marked this pull request as ready for review July 2, 2024 08:47
@hamza221 hamza221 requested a review from ShGKme July 2, 2024 08:47
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thanks!

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 merged commit c21dd7e into main Jul 2, 2024
46 checks passed
@hamza221 hamza221 deleted the feat/ooo-replacement branch July 2, 2024 14:28
@danxuliu danxuliu mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

5 participants