Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "show transmissions" toggle to be defined via URL query #1155

Closed
jameshadfield opened this issue Jun 3, 2020 · 0 comments · Fixed by #1165
Closed

Allow "show transmissions" toggle to be defined via URL query #1155

jameshadfield opened this issue Jun 3, 2020 · 0 comments · Fixed by #1165

Comments

@jameshadfield
Copy link
Member

Context

#1147 introduced a toggle to control whether we show transmissions on the map. #1152 allowed the state of this toggle to be set via the JSON. #1154 will make this toggle This toggle is always present, regardless of whether the data is actually present in the tree. If transmissions are not defined by the tree, then the toggle has no real effect.

Description

We want the toggle state to be definable via a URL query, similar to many other aspects of auspice. This flow chart explains how this query state should interact with other variables:

transmission_query

Changes to the toggle state (via user interaction) should also update the query - removing it if the new state matches the default, and adding it if it differs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant