Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve matching algorithm of filter UI #1233

Closed
jameshadfield opened this issue Nov 19, 2020 · 1 comment
Closed

Improve matching algorithm of filter UI #1233

jameshadfield opened this issue Nov 19, 2020 · 1 comment

Comments

@jameshadfield
Copy link
Member

The filter search box (see #1200) currently matches on the label key. Values of these look like

country → USA
country → South Africa
country → New Zealand
...

The matching algorithm behind React Select seems to require complete matching of the provided string in that list (case insensitive). So, for instance, new zealand matches fine, however country new zealand doesn't (country → new zealand would be required). This should be improved.
@snyk-bot snyk-bot mentioned this issue Nov 18, 2020
Closed
@joverlee521
Copy link
Contributor

Duplicate of #1271

@joverlee521 joverlee521 marked this as a duplicate of #1271 Feb 18, 2022
@cmlsn cmlsn mentioned this issue Apr 19, 2022
Closed
@jmontmaxwell jmontmaxwell mentioned this issue Dec 25, 2022
Open
@BinamB BinamB mentioned this issue Nov 27, 2023
Open
@BinamB BinamB mentioned this issue Dec 19, 2023
Open
@BinamB BinamB mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameshadfield @joverlee521