Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically add tip labels #237

Closed
trvrb opened this issue Feb 28, 2017 · 6 comments
Closed

Dynamically add tip labels #237

trvrb opened this issue Feb 28, 2017 · 6 comments
Assignees
Labels

Comments

@trvrb
Copy link
Member

trvrb commented Feb 28, 2017

For SVG performance (especially when transitioning), we need to dynamically add and remove branchLabels and tipLabels from the DOM. With a zoomed tree with labels showing, I bet it's going to be safe to transition the ones that are visible.

@jameshadfield
Copy link
Member

jameshadfield commented Feb 28, 2017

Somewhat temporarily fixed in c347f58 where I draw tip labels iff < 50 tips inView, and they appear after the branches/tips have transitioned

@jameshadfield
Copy link
Member

jameshadfield commented Mar 15, 2017

  • only active / "on" tips have labels
  • new tips come into view via a L->R transition
  • pan doesn't change active tips pan has been removed from the tree
  • better tip in/out transitions
  • the hardcoded # of branches selected should only count "visibile" tips
  • changing tree layouts sometimes results in tips not being displayed when they should

@jameshadfield jameshadfield self-assigned this Mar 16, 2017
@jameshadfield jameshadfield changed the title Dynamically add / remove branchLabels and tipLabels Dynamically add tip labels Mar 2, 2018
@jameshadfield jameshadfield added enhancement New feature or request high priority labels Mar 2, 2018
@jameshadfield jameshadfield removed their assignment Oct 30, 2018
@kairstenfay kairstenfay self-assigned this May 31, 2019
@kairstenfay
Copy link
Contributor

kairstenfay commented May 31, 2019

@jameshadfield should tip labels be re-calculated each time drawTips() is called?

Or rather, every time setLayout() is called?

@kairstenfay
Copy link
Contributor

I believe commit 579c524 addresses the final bullet point.

@kairstenfay
Copy link
Contributor

#728 addresses the parts of this issue where tip label visibility would not update after Date Range change, and where tip labels would not re-appear after layout change.

@jameshadfield
Copy link
Member

Closing in favor of #915 #916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants