Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch with new DNAScope ML model format #568

Open
Jakob37 opened this issue Jun 13, 2024 · 3 comments
Open

Mismatch with new DNAScope ML model format #568

Jakob37 opened this issue Jun 13, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Jakob37
Copy link
Contributor

Jakob37 commented Jun 13, 2024

Description of the bug

The Sentieon DNAScope takes a flag --model which is expected to point to a file with a pre-trained model.

In their latest updates, the models are provided in .bundle format. Here the model is accessed as such:

--model /path/to/models.bundle/dnascope.model

(More info in issue here: Sentieon/sentieon-models#4)

But, the file is actually named models.bundle.

So if you point to the models.bundle directly, the Sentieon process does currently not find the file. If pointing directly to dnascope.model, Nextflow will detect it as missing and will not run.

My temporary solution is to update the Sentieon DNA-scope module code as such:

def model_cmd                 = ml_model                           ? " --model ${ml_model}/dnascope.model"   : ''

Command used and terminal output

No response

Relevant files

No response

System information

No response

@Jakob37 Jakob37 added the bug Something isn't working label Jun 13, 2024
@asp8200
Copy link
Contributor

asp8200 commented Jun 13, 2024

Yeah, we need to fix that. In the mean time, you can unpack the bundle using ar and get hold of the module-file you need.

EDIT: Your fix is also fine.

@Jakob37
Copy link
Contributor Author

Jakob37 commented Jun 13, 2024

Yeah, we need to fix that. In the mean time, you can unpack the bundle using ar and get hold of the module-file you need.

EDIT: Your fix is also fine.

Didn't know that, thanks!

@maxulysse
Copy link
Member

xref: nf-core/sarek#1399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants