Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature record can be only v2.0 #8

Open
merlokk opened this issue Nov 24, 2021 · 1 comment
Open

Signature record can be only v2.0 #8

merlokk opened this issue Nov 24, 2021 · 1 comment

Comments

@merlokk
Copy link

merlokk commented Nov 24, 2021 •
edited
Loading

Hi

https://github.com/haldean/ndef/blob/master/docs/NFCForum-TS-Signature_RTD-1.0.pdf

here the specification

here: 3028b2a i see change from byte to word. I don't have v2.0 specification but as for v.1 (or as in the decoder v0.1) here byte lengths.

i can modify the current Signature class to support v1 and v2 cases. Is this ok?
@nehpetsde
Copy link
Member

The length field is 16-bits in both version 1 and 2 of the Signature specification. It has been a bug in ndeflib to encode it as 8-bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@merlokk @nehpetsde