Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Configuration of SnippetsFilter to NGINX #2417

Closed
2 of 3 tasks
Tracked by #703
mpstefan opened this issue Aug 19, 2024 · 0 comments
Closed
2 of 3 tasks
Tracked by #703

Apply Configuration of SnippetsFilter to NGINX #2417

mpstefan opened this issue Aug 19, 2024 · 0 comments
Assignees
Labels
area/nginx-configuration Relates to nginx configuration enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks
Milestone

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Aug 19, 2024

As a user of NGF
I want my SnippetsFilter configuration applied to NGF's data plane
So that I can leverage NGINX features not yet available in NGF.

Acceptance

  • The SnippetsFilters is validated to ensure it only contains valid contexts:
    • main
    • http
    • server
    • location
  • The SnippetsFilter only allows one snippet per context.
  • If a resolvedRef of a SnippetsFilter is found to be invalid for a given Route rule, that Route rule is configured to return a service unavailable response that is appropriate for the route.
  • Configuration defined in a filter attached to a route rule applies the NGINX directive configuration specified in the filter.
  • SnippetsFilters are disabled by default
  • SnippetsFilters must be explicitly enabled.

Tasks

@mpstefan mpstefan changed the title Implement Contents of SnippetsFilter to NGINX Apply Configuration of SnippetsFilter to NGINX Aug 19, 2024
@mpstefan mpstefan added enhancement New feature or request area/nginx-configuration Relates to nginx configuration labels Aug 19, 2024
@mpstefan mpstefan added this to the v1.5.0 milestone Aug 19, 2024
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks labels Sep 3, 2024
@kate-osborn kate-osborn self-assigned this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/nginx-configuration Relates to nginx configuration enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks
Projects
Status: Done
Development

No branches or pull requests

3 participants