Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on nix-shell in shell scripts #2

Open
ninegua opened this issue Sep 24, 2019 · 1 comment
Open

Remove dependency on nix-shell in shell scripts #2

ninegua opened this issue Sep 24, 2019 · 1 comment

Comments

@ninegua
Copy link
Owner

ninegua commented Sep 24, 2019

The current shell scripts (keygen.sh and yubicopy.sh) use nix-shell because they can be useful outside the USB drive too. But using them first time after booting into the USB drive will require Internet access to download some dev packages, which are actually not needed for running them.

To enable a fully functional offline setup, we should package the shell scripts properly as a nix derivation that can be separately installed.
@ninegua
Copy link
Owner Author

ninegua commented Oct 1, 2019

Commit 8ab8bd7 installs both scripts, with a main caveat: the script assumes suitable commands are in PATH, instead of embedding them. This is perhaps desirable because the same script might survive software upgrades or bug fixes, if a user choose to install new versions manually on the USB drive.

@ninegua ninegua closed this as completed Oct 1, 2019
@ninegua ninegua reopened this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ninegua