Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraPostVM docs: recommendation doesn't work, would be potentially destructive if it did #774

Open
colemickens opened this issue Sep 15, 2024 · 0 comments

Comments

@colemickens
Copy link
Member

  1. The impure script uses $PWD to build the disk image.
  2. There's no protections for an existing disk image in "$out".
  3. The option documentation for extraPostVM:
    i. doesn't work, you can't glob in a script like that
    ii. if it did work, would affect ANY .raw files in $PWD/"$out" (which could be bad!)
    iii. is just a bit unfortunate, it would be a great place to show the user how to actually get the disk image name

I think when I looked the other day, the disk image name isn't straight forward to recompose and isn't stashed. So maybe a way to fix this is to just move the disk name to an exported system.build.disko... whatever attribute, and then use it. Then the user can use that attr to reference the image path in extraPostVM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant