Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvnix-update uses .override which blocks the use of callPackage #18

Closed
FRidh opened this issue Apr 3, 2019 · 2 comments
Closed

mvnix-update uses .override which blocks the use of callPackage #18

FRidh opened this issue Apr 3, 2019 · 2 comments

Comments

@FRidh
Copy link
Contributor

FRidh commented Apr 3, 2019

Consider the file builder.nix

{ mavenix, ... }:

mavenix.buildMaven {
...
}

and

{
  foo = callPackage ./builder { };
}

Using mvnix-update -E "(import ./.).foo" will fail because .override is redefined by callPackage. This is a common issue, and can be worked around by the user, however, I think it would be better if buildMaven defines an overrideAttrs instead.

For Python I introduced at the time overridePythonAttrs, but in retrospect I think all specific builders should re-define overrideAttrs. See also NixOS/nixpkgs#46842 (comment).

@icetan
Copy link
Collaborator

icetan commented Apr 3, 2019

Something like this #19?

@FRidh
Copy link
Contributor Author

FRidh commented Apr 15, 2019

This has been fixed.

@FRidh FRidh closed this as completed Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants