-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append version to include.zip #1412
Comments
In fact, the version is in the URL: |
While I appreciate that, the end result is still include.zip, which is the primary issue. |
I have to see. Adding the include folder was already something I did for other systems. I'm afraid changing the name would break their system now. |
I hope not! I don't want to break other systems! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hello!
First off; I want to thank you guys for making such a wonderful library!
I was wondering if it would be possible to append the version number to each include.zip file that's released from now on. I contribute to the BuildRoot project, and it would be wonderful not to have to download the entire tarball.
If you take a look at https://patchwork.ozlabs.org/patch/1019719/ you will see the issue with using include.zip.
"Thanks to the hash, the right version of the file will be
re-downloaded, but this will entirely break sources.buildroot.net, in
the sense that they will not be able to provide include.zip for older
Buildroot versions, that use an older version of json-for-modern-cpp."
It's a small thing, but it would be MUCH appreciated if you guys would be willing to do this for us.
Thanks!
Adam
The text was updated successfully, but these errors were encountered: