Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append version to include.zip #1412

Closed
aduskett opened this issue Jan 2, 2019 · 5 comments
Closed

Append version to include.zip #1412

aduskett opened this issue Jan 2, 2019 · 5 comments
Labels
state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated

Comments

@aduskett
Copy link

aduskett commented Jan 2, 2019

Hello!

First off; I want to thank you guys for making such a wonderful library!
I was wondering if it would be possible to append the version number to each include.zip file that's released from now on. I contribute to the BuildRoot project, and it would be wonderful not to have to download the entire tarball.

If you take a look at https://patchwork.ozlabs.org/patch/1019719/ you will see the issue with using include.zip.

"Thanks to the hash, the right version of the file will be
re-downloaded, but this will entirely break sources.buildroot.net, in
the sense that they will not be able to provide include.zip for older
Buildroot versions, that use an older version of json-for-modern-cpp."

It's a small thing, but it would be MUCH appreciated if you guys would be willing to do this for us.

Thanks!

Adam

@aduskett aduskett changed the title Add version to include.zip Append version to include.zip Jan 2, 2019
@nlohmann
Copy link
Owner

nlohmann commented Jan 2, 2019

In fact, the version is in the URL: https://github.com/nlohmann/json/releases/download/v3.5.0/include.zip.

@aduskett
Copy link
Author

aduskett commented Jan 2, 2019

While I appreciate that, the end result is still include.zip, which is the primary issue.
Would it be possible to instead call it include-v3.5.0.zip ?

@nlohmann
Copy link
Owner

nlohmann commented Jan 3, 2019

I have to see. Adding the include folder was already something I did for other systems. I'm afraid changing the name would break their system now.

@aduskett
Copy link
Author

aduskett commented Jan 9, 2019

I hope not! I don't want to break other systems!

@stale
Copy link

stale bot commented Feb 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Feb 8, 2019
@stale stale bot closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated
Projects
None yet
Development

No branches or pull requests

2 participants