Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBOR byte string support #1509

Closed
ayounes-nviso opened this issue Mar 11, 2019 · 3 comments
Closed

CBOR byte string support #1509

ayounes-nviso opened this issue Mar 11, 2019 · 3 comments

Comments

@ayounes-nviso
Copy link

There is already a ticket on that issue: #1129
I could not re-open this ticket and I am not sure if our comments there are noticed by someone. Sorry about the duplication if the notification on closed ticket are actually working.

We (NVISO) are willing to contribute to this feature if you can give us some pointer where to start.

Thanks in advance and best regards,
Abdel

@ayounes-nviso
Copy link
Author

ayounes-nviso commented Mar 11, 2019

BTW, this project already supports incremental loading of CBOR, including Byte arrays:
https://github.com/danielaparker/jsoncons

Maybe we can borrow some code if the license are compatible (there are using Boost Software License, Version 1.0).

@nlohmann
Copy link
Owner

I reopened #1129. Let's have the discussion there. Closing this issue to avoid duplicates.

It would be great to see some progress on binary support. Even better would be an idea that also works with MessagePack, UBJSON :)

@nlohmann
Copy link
Owner

Fixed with #1662.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants