Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Switches -Weffc++ & -Wshadow are throwing errors #1558

Closed
LoeFe opened this issue Apr 4, 2019 · 2 comments
Closed

Compiler Switches -Weffc++ & -Wshadow are throwing errors #1558

LoeFe opened this issue Apr 4, 2019 · 2 comments
Labels
kind: bug state: needs more info the author of the issue needs to provide more details

Comments

@LoeFe
Copy link

LoeFe commented Apr 4, 2019

  • What is the issue you have?
    When Compiling the lib with -Weffc++ & -Wshadow the compiler returns with error

  • Please describe the steps to reproduce the issue. Can you provide a small but working code example?
    Use gcc and compile the code

  • What is the expected behavior?
    No errors are returned

  • And what is the actual behavior instead?
    The lib doesn't compile with these switches

  • Which compiler and operating system are you using? Is it a supported compiler?
    GCC 4.8.5 on a windows system compiling apps that are running under linux

  • Did you use a released version of the library or the version from the develop branch?
    release

  • If you experience a compilation error: can you compile and run the unit tests?

@LoeFe LoeFe added the kind: bug label Apr 4, 2019
@nlohmann
Copy link
Owner

nlohmann commented Apr 4, 2019

How did you compile the code? What is the exact error output?

@nlohmann nlohmann added the state: needs more info the author of the issue needs to provide more details label Apr 5, 2019
@LoeFe
Copy link
Author

LoeFe commented Apr 8, 2019

I used to compile with gcc 7.2.x and changed back to an older one (4.8.5).

But in the meantime I've changed to gcc 8.2.0 and now it works. Sry for that and thanks for your immediate reply.

@LoeFe LoeFe closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug state: needs more info the author of the issue needs to provide more details
Projects
None yet
Development

No branches or pull requests

2 participants