xwidgets doesn't compile with version >3.10.3 #3602
Comments
|
I can reproduce the issue and trace it back to the same |
|
@falbrechtskirchinger is this a band-aid for |
|
For |
|
@falbrechtskirchinger also if you don't mind, I'd like to understand what's going on in here and why it's causing the error. I have no affiliation with either of the libraries and it took me a while to figure out what I have so far. |
|
The issue is this template <template <class> class B, class... P>
template <class... A>
inline xmaterialize<B, P...>::xmaterialize(A&&... args)
: xmaterialize(false, std::forward<A>(args)...)
{
}The band-aid consists of re-adding the check for a I've started a discussion (#3603) to try and fix issues like this one in 4.0. |
|
@falbrechtskirchinger thank you, I understand now. As a workaround, what if I replaced |
|
... or I suppose, I can roll my own version with your fresh-off-the-press patch, since you are so fast. 🥇 🥇 🥇 |
|
You could try calling Grabbing my patch is likely going to be more fruitful. |
|
OK I will try both. Thank you for such a fast response. 😃 |
|
Well, unless I'm using the wrong header, it's not actually working. :-( In that case, you'll have to wait until tomorrow. |
|
@falbrechtskirchinger yep, I can confirm that neither of the methods worked for me. |
|
@falbrechtskirchinger FWIW if I patch |
|
Commit 261cc4e is the other culprit that's causing failure on the diff --git a/include/nlohmann/detail/conversions/from_json.hpp b/include/nlohmann/detail/conversions/from_json.hpp
index 207d3e3024..cc06f198b4 100644
--- a/include/nlohmann/detail/conversions/from_json.hpp
+++ b/include/nlohmann/detail/conversions/from_json.hpp
@@ -105,13 +105,12 @@ void from_json(const BasicJsonType& j, typename BasicJsonType::string_t& s)
}
template <
- typename BasicJsonType, typename ConstructibleStringType,
+ typename BasicJsonType, typename StringType,
enable_if_t <
- is_constructible_string_type<BasicJsonType, ConstructibleStringType>::value&&
- !std::is_same<typename BasicJsonType::string_t,
- ConstructibleStringType>::value,
- int > = 0 >
-void from_json(const BasicJsonType& j, ConstructibleStringType& s)
+ std::is_assignable<StringType&, const typename BasicJsonType::string_t>::value
+ && !std::is_same<typename BasicJsonType::string_t, StringType>::value
+ && !is_json_ref<StringType>::value, int > = 0 >
+void from_json(const BasicJsonType& j, StringType& s)
{
if (JSON_HEDLEY_UNLIKELY(!j.is_string()))
{ |
|
Thanks for confirming. I already suspected that it might very well work with 3.10.5. Several issues caused by 0e694b4 were addressed in the 3.11.0 development cycle, and there were bound to be some mistakes. |
|
Adding the same |
|
Thanks @falbrechtskirchinger. I ended up throwing a patched version of Once 3.11 is out, I will undo all that. Thank you for your help. 🎩 🎩 🎩 |
Is this going to break other types that are actually string types and are now working but don't have a |
|
Edit: Nope, nonsense. The change was made for 3.10.4. We'd be going back to the 3.10.3 days. I don't really like it, but a proper solution requires a bit more thought. Basically, we need some trait that users are allowed to specialize for custom types. Edit: Maybe there's a better workaround? Related discussion post: #3603 |
nlohmann
added
the
solution: proposed fix
Description
The xwidgets project, which uses this library stopped compiling after version 3.10.3. Specifically, commit 0e694b4 is responsible for the problem.
Even more specifically, redefinition of
is_constructible_string_typefrom this:json/include/nlohmann/detail/meta/type_traits.hpp
Lines 331 to 348 in aa0e847
to this:
json/include/nlohmann/detail/meta/type_traits.hpp
Lines 319 to 325 in 0e694b4
is what's causing the error.
The exact part of
xwidgetswhere the error happens is here:I know
xwidgetssays that they are only compatible withjsonversion <3.10, but most up-to-date linux distros only supply 3.10.5. Plus, everything used to work up until the above commit.Reproduction steps
Install
xeus-devandxproperty-devdependencies from my ppa:ppa-verse/cling repo.Download and unpack: xwidgets_0.26.1.orig.tar.gz
Download (remove .txt) and unpack inside
xwidgets-0.26.1above: xwidgets_0.26.1-0ppa2.debian.tar.xz.txtExecute
dpkg-buildpackage -uc -us -bExpected vs. actual results
Expected: Successful compilation and creation of
xwidgetsdebian package.Actual: Failed compilation. (See error messages below and attached build log).
buildlog_ubuntu-jammy-amd64.xwidgets_0.26.1-0ppa2_ubuntu22.04_BUILDING.zip
Minimal code example
No response
Error messages
In file included from /root/xwidgets/include/xwidgets/xaudio.hpp:16, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xmaterialize.hpp: In instantiation of 'xw::xmaterialize<B, P>::xmaterialize(bool, A&& ...) [with A = {const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&}; B = xw::xlayout; P = {}]': /root/xwidgets/include/xwidgets/xmaterialize.hpp:66:55: required from 'xw::xmaterialize<B, P>::xmaterialize(A&& ...) [with A = {const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&}; B = xw::xlayout; P = {}]' /usr/include/nlohmann/detail/conversions/from_json.hpp:111:7: required from 'void nlohmann::detail::from_json(const BasicJsonType&, ConstructibleStringType&) [with BasicJsonType = nlohmann::basic_json<>; ConstructibleStringType = xw::xmaterialize<xw::xlayout>; typename std::enable_if<(nlohmann::detail::is_constructible_string_type<BasicJsonType, ConstructibleStringType>::value && (! std::is_same<typename BasicJsonType::string_t, ConstructibleStringType>::value)), int>::type <anonymous> = 0]' /usr/include/nlohmann/detail/conversions/from_json.hpp:470:25: required from 'decltype (nlohmann::detail::from_json(j, forward<T>(val))) nlohmann::detail::from_json_fn::operator()(const BasicJsonType&, T&&) const [with BasicJsonType = nlohmann::basic_json<>; T = xw::xmaterialize<xw::xlayout>&; decltype (nlohmann::detail::from_json(j, forward<T>(val))) = void]' /usr/include/nlohmann/adl_serializer.hpp:33:30: required from 'static decltype ((nlohmann::{anonymous}::from_json(forward<BasicJsonType>(j), val), void())) nlohmann::adl_serializer<T, SFINAE>::from_json(BasicJsonType&&, TargetType&) [with BasicJsonType = const nlohmann::basic_json<>&; TargetType = xw::xmaterialize<xw::xlayout>; ValueType = xw::xmaterialize<xw::xlayout>; <template-parameter-1-2> = void; decltype ((nlohmann::{anonymous}::from_json(forward<BasicJsonType>(j), val), void())) = void]' /usr/include/nlohmann/json.hpp:3073:45: required from 'ValueType nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::get_impl(nlohmann::detail::priority_tag<0>) const [with ValueType = xw::xmaterialize<xw::xlayout>; typename std::enable_if<(nlohmann::detail::is_default_constructible<ValueType>::value && nlohmann::detail::has_from_json<nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>, ValueType>::value), int>::type <anonymous> = 0; ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>]' /usr/include/nlohmann/json.hpp:3216:35: required from 'constexpr decltype (declval<const basic_json_t&>().get_impl<ValueType>(nlohmann::detail::priority_tag<4>{})) nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::get() const [with ValueTypeCV = xw::xmaterialize<xw::xlayout>; ValueType = xw::xmaterialize<xw::xlayout>; ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; decltype (declval<const basic_json_t&>().get_impl<ValueType>(nlohmann::detail::priority_tag<4>{})) = xw::xmaterialize<xw::xlayout>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::basic_json_t = nlohmann::basic_json<>]' /root/xwidgets/include/xwidgets/xcommon.hpp:46:34: required from 'void xw::xwidgets_deserialize(T&, const json&, const buffer_sequence&) [with T = xw::xmaterialize<xw::xlayout>; nlohmann::json = nlohmann::basic_json<>; xeus::buffer_sequence = std::vector<std::vector<char> >]' /root/xwidgets/include/xwidgets/xtransport.hpp:37:33: required from 'void xw::set_property_from_patch(P&, const json&, const buffer_sequence&) [with P = xp::xproperty<xw::xmaterialize<xw::xlayout>, xw::xmaterialize<xw::xaudio> >; nlohmann::json = nlohmann::basic_json<>; xeus::buffer_sequence = std::vector<std::vector<char> >]' /root/xwidgets/include/xwidgets/xwidget.hpp:73:32: required from 'void xw::xwidget<D>::apply_patch(const json&, const buffer_sequence&) [with D = xw::xmaterialize<xw::xaudio>; nlohmann::json = nlohmann::basic_json<>; xeus::buffer_sequence = std::vector<std::vector<char> >]' /root/xwidgets/include/xwidgets/xmedia.hpp:68:31: required from 'void xw::xmedia<D>::apply_patch(const json&, const buffer_sequence&) [with D = xw::xmaterialize<xw::xaudio>; nlohmann::json = nlohmann::basic_json<>; xeus::buffer_sequence = std::vector<std::vector<char> >]' /root/xwidgets/include/xwidgets/xaudio.hpp:71:31: required from 'void xw::xaudio<D>::apply_patch(const json&, const buffer_sequence&) [with D = xw::xmaterialize<xw::xaudio>; nlohmann::json = nlohmann::basic_json<>; xeus::buffer_sequence = std::vector<std::vector<char> >]' /root/xwidgets/include/xwidgets/xtransport.hpp:192:45: required from 'void xw::xtransport<D>::handle_message(const xeus::xmessage&) [with D = xw::xmaterialize<xw::xaudio>]' /root/xwidgets/src/xaudio.cpp:10:33: required from here /root/xwidgets/include/xwidgets/xmaterialize.hpp:74:69: error: no matching function for call to 'xw::xlayout<xw::xmaterialize<xw::xlayout> >::xlayout(const std::__cxx11::basic_string<char>&)' 74 | : base_type(std::forward<A>(args)...), m_generator(generator) | ^ In file included from /root/xwidgets/include/xwidgets/xobject.hpp:18, from /root/xwidgets/include/xwidgets/xlayout.hpp:16, from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xtransport.hpp:132:12: note: candidate: 'xw::xtransport<D>::xtransport(xw::xtransport<D>&&) [with D = xw::xmaterialize<xw::xlayout>]' 132 | inline xtransport<D>::xtransport(xtransport&& other) | ^~~~~~~~~~~~~ In file included from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: inherited here 65 | using base_type::base_type; | ^~~~~~~~~ /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: an inherited constructor is not a candidate for initialization from an expression of the same or derived type In file included from /root/xwidgets/include/xwidgets/xobject.hpp:18, from /root/xwidgets/include/xwidgets/xlayout.hpp:16, from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xtransport.hpp:124:12: note: candidate: 'xw::xtransport<D>::xtransport(const xw::xtransport<D>&) [with D = xw::xmaterialize<xw::xlayout>]' 124 | inline xtransport<D>::xtransport(const xtransport& other) | ^~~~~~~~~~~~~ In file included from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: inherited here 65 | using base_type::base_type; | ^~~~~~~~~ /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: an inherited constructor is not a candidate for initialization from an expression of the same or derived type In file included from /root/xwidgets/include/xwidgets/xobject.hpp:18, from /root/xwidgets/include/xwidgets/xlayout.hpp:16, from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xtransport.hpp:113:12: note: candidate: 'xw::xtransport<D>::xtransport(xeus::xcomm&&, bool) [with D = xw::xmaterialize<xw::xlayout>]' 113 | inline xtransport<D>::xtransport(xeus::xcomm&& comm, bool owning) | ^~~~~~~~~~~~~ In file included from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: inherited here 65 | using base_type::base_type; | ^~~~~~~~~ In file included from /root/xwidgets/include/xwidgets/xobject.hpp:18, from /root/xwidgets/include/xwidgets/xlayout.hpp:16, from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xtransport.hpp:113:52: note: no known conversion for argument 1 from 'const std::__cxx11::basic_string<char>' to 'xeus::xcomm&&' 113 | inline xtransport<D>::xtransport(xeus::xcomm&& comm, bool owning) | ~~~~~~~~~~~~~~^~~~ In file included from /root/xwidgets/include/xwidgets/xlayout.hpp:16, from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xobject.hpp:27:11: note: candidate: 'xw::xobject<xw::xmaterialize<xw::xlayout> >::xobject(const xw::xobject<xw::xmaterialize<xw::xlayout> >&)' 27 | class xobject : public xtransport<D> | ^~~~~~~ In file included from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: inherited here 65 | using base_type::base_type; | ^~~~~~~~~ /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: an inherited constructor is not a candidate for initialization from an expression of the same or derived type In file included from /root/xwidgets/include/xwidgets/xlayout.hpp:16, from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xobject.hpp:27:11: note: candidate: 'xw::xobject<xw::xmaterialize<xw::xlayout> >::xobject(xw::xobject<xw::xmaterialize<xw::xlayout> >&&)' 27 | class xobject : public xtransport<D> | ^~~~~~~ In file included from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: inherited here 65 | using base_type::base_type; | ^~~~~~~~~ /root/xwidgets/include/xwidgets/xlayout.hpp:65:26: note: an inherited constructor is not a candidate for initialization from an expression of the same or derived type /root/xwidgets/include/xwidgets/xlayout.hpp:139:12: note: candidate: 'xw::xlayout<D>::xlayout() [with D = xw::xmaterialize<xw::xlayout>]' 139 | inline xlayout<D>::xlayout() | ^~~~~~~~~~ /root/xwidgets/include/xwidgets/xlayout.hpp:139:12: note: candidate expects 0 arguments, 1 provided In file included from /root/xwidgets/include/xwidgets/xwidget.hpp:15, from /root/xwidgets/include/xwidgets/xmedia.hpp:18, from /root/xwidgets/include/xwidgets/xaudio.hpp:17, from /root/xwidgets/src/xaudio.cpp:1: /root/xwidgets/include/xwidgets/xlayout.hpp:25:11: note: candidate: 'xw::xlayout<xw::xmaterialize<xw::xlayout> >::xlayout(const xw::xlayout<xw::xmaterialize<xw::xlayout> >&)' 25 | class xlayout : public xobject<D> | ^~~~~~~ /root/xwidgets/include/xwidgets/xlayout.hpp:25:11: note: no known conversion for argument 1 from 'const std::__cxx11::basic_string<char>' to 'const xw::xlayout<xw::xmaterialize<xw::xlayout> >&' /root/xwidgets/include/xwidgets/xlayout.hpp:25:11: note: candidate: 'xw::xlayout<xw::xmaterialize<xw::xlayout> >::xlayout(xw::xlayout<xw::xmaterialize<xw::xlayout> >&&)' /root/xwidgets/include/xwidgets/xlayout.hpp:25:11: note: no known conversion for argument 1 from 'const std::__cxx11::basic_string<char>' to 'xw::xlayout<xw::xmaterialize<xw::xlayout> >&&' make[3]: *** [CMakeFiles/xwidgets-static.dir/build.make:93: CMakeFiles/xwidgets-static.dir/src/xaudio.cpp.o] Error 1Compiler and operating system
Ubuntu 22.04, gcc 11.2.0
Library version
v3.10.3 + 0e694, v3.10.5, develop
Validation
developbranch is used.The text was updated successfully, but these errors were encountered: