Missing break after line 12886 in switch/case

[jamespharvey20]

case lexer::token_type::parse_error:
{
   // using "uninitialized" to avoid "expected" message
   expect(lexer::token_type::uninitialized); // line 12886
}

On gcc 7.2.0, with -Werror, this causes:

json.hpp:12886:27: error: this statement may fall through [-Werror=implicit-fallthrough=]
                     expect(lexer::token_type::uninitialized);
                     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
json.hpp:12889:17: note: here
                 default:
                 ^~~~~~~
cc1plus: all warnings being treated as errors

This is of course worked around by including the json directory as a system directory.

And, it's sort of a non-issue because if expect() throws, it never falls through, and if it doesn't throw the first time, it won't throw the second time.

[nlohmann]

This should be fixed in the latest develop version. There, the code is

case token_type::parse_error:
{
    // using "uninitialized" to avoid "expected" message
    if (not expect(token_type::uninitialized))
    {
        return;
    }
    break; // LCOV_EXCL_LINE
}

[nlohmann]

@jamespharvey20 Could you please try the most recent develop version?

[jamespharvey20]

@nlohmann, sorry, yes, develop fixes this issue. Thanks!