Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change landed in v9.6.0 #312

Closed
MylesBorins opened this issue Feb 22, 2018 · 3 comments
Closed

Breaking change landed in v9.6.0 #312

MylesBorins opened this issue Feb 22, 2018 · 3 comments

Comments

@MylesBorins
Copy link
Contributor

nodejs/node#17403 (comment) for reference

TLDR a commit landed that should have arguably been semver major. Should we do another release today or wait until next week?
@gibfahn
Copy link
Member

gibfahn commented Feb 22, 2018

I think the quicker the better. Reverting this is arguably a semver-major change too, so the longer it's out there as latest the worse it is.

Obviously if no-one has the bandwidth to do another release right now then next week hopefully isn't the end of the world.

@watson could you give an idea of how many people you think this might break?

@MylesBorins
Copy link
Contributor Author

we have a fix open nodejs/node#18944

If CI is green I'll put together a release and get it out tonight

@MylesBorins
Copy link
Contributor Author

v9.6.1 is out the door

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MylesBorins @gibfahn