NEEDED CONTRIBUTOR! The Node.js CoC in one place.

[hackygolucky]

A great opportunity for someone wanted to get some pull requests in Node.js. Per these issues, nodejs/TSC#224 (comment) and #7, Node.js is trying to consolidate the CoC into one place so that when it is updated, it is updated across all places it's been referenced instead of copy/pasted.

So, other versions meant to be representing the source CoC should be replaced as links pointing to The Code of Conduct.

[hackygolucky]

Is is safe to copy/paste the list from #7 in this description for people to swap out? Or is there diffing to be done first?

[williamkapke]

You can C&P it here if you want. The diff-ing part will be part of this task.

[mhdawson]

If nobody has volunteered I can start this in the background, starting with the WG's that I'm involved in.

[mhdawson]

Initial PR for change in benchmarking WG, let me know if you think this is a good way to do it:

nodejs/benchmarking#112

[nebrius]

Thanks for getting the ball rolling @mhdawson! The PR looks good to me, thanks for wordsmithing that.

[therebelrobot]

Is this still a good place for contribution? The linked PR seems like it's been superseded by a TSC decision, but it wasn't clear where the status of this endeavor stands. Is there an independent repo for it at this point?

[hackygolucky]

@therebelrobot This would be a perfect place to contribute! It looks like the PR and issue linked were merged and closed, but the list in #7 is still a good reference of what still needs to be modified. It should have been copied over for someone to tackle that before we closed it.

If you'd like to plow through that list and replace the Code of Conduct with the example that @mhdawson linked https://github.com/nodejs/benchmarking/pull/112/files, that would be amazing! I would recommend referencing the TSC issue when you file each pull request so that the working groups are updated on context.

[therebelrobot]

Sounds like a plan. Moving the list over here for tracking:

The primary copy:

nodejs/node:CODE_OF_CONDUCT.md@master

Copies I found (I'll edit this as I go along to add direct links to PRs)

• nodejs/community-committee:CODE_OF_CONDUCT.MD@master
• nodejs/community-committee:COLLABORATOR_GUIDE.MD@master
• nodejs/post-mortem:CONTRIBUTING.md@master
• nodejs/benchmarking:CONTRIBUTING.md@master
• nodejs/http2:CODE_OF_CONDUCT.md@master
• nodejs/evangelism:CONTRIBUTING.md@master
• nodejs/Intl:CONTRIBUTING-draft.md@master
• nodejs/nodejs-uk:CONTRIBUTING.md@master
• nodejs/nodejs.org:COLLABORATOR_GUIDE.md@master
• nodejs/docs:CONTRIBUTING.md@master
• nodejs/nodejs-hu:content/en/working-groups.md@master

These are special cases (should these be looked at? Or should I leave them be?):

• nodejs/node-chakracore:CODE_OF_CONDUCT.md@master
• nodejs/iojs.org:CONTRIBUTING.md@master
• nodejs/inclusivity:CODE_OF_CONDUCT.md@master
• nodejs/node-convergence-archive:CONTRIBUTING.md@master
• nodejs/docker-node:GOVERNANCE.md@master
• nodejs/docker-iojs:GOVERNANCE.md@master

Also, I'm assuming I'm just replacing the CoC portions with a link out, rather than the whole body of the text where appropriate. I'm seeing a few instances above that are referring to the contributors guide of the repo, which could have a broader scope than just the CoC, and should probably be left intact up until that point.

[hackygolucky]

@therebelrobot yeah, only replace the CoC content with the linked sentence. Since they are all pull requests anyway, individuals can give feedback if the change should be different. As for nodejs/inclusivity, we need to archive that repo. A possible reason you'll get pushback on a pull request: the case where a CoC is stricter than the general Node.js CoC. In that case, afaik, they are allowed to do that. It just can't be more lax.

and thanks again!

[mhdawson]

I'd start with the copies and then once those are done we probably want to at least ping the wg's with special cases to see if they want to keep a different version or the differences are just historical.

[nebrius]

Thanks for looking into this @therebelrobot! Quick question for you: you mentioned that the primary copy is at nodejs/node. Do you mean the primary copy of the CoC itself, or the primary wording for the link to the CoC? FWIW the official version of the CoC is at nodejs/TSC:CODE_OF_CONDUCT.md@master

[therebelrobot]

@mhdawson sounds like a plan. I could probably get a diff of what they have and what the central one is, add it to the PRs, and ask if that diff is intentional or drift.

@nebrius I pulled this language in specific from #7 - I can make sure it's a link to nodejs/TSC:CODE_OF_CONDUCT.md@master for sure.

As for timeline, most of my open source work is done on the weekends, I'm setting aside time on Saturday to open all these PRs. Is there need to allocate time before then? If so I can shuffle some things around.

[RichardLitt]

As for timeline, most of my open source work is done on the weekends, I'm setting aside time on Saturday to open all these PRs. Is there need to allocate time before then? If so I can shuffle some things around.

I don't think so. Thank you, and take your time!

[ghost]

closed by #190