-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for failure on crash of CallbackScope::Close on testing #979
Comments
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
Hi @legendecas should this have been closed? |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
From discussion in the team meeting, we have a work around in main branch so it does not crash there but this is open as we need a better fix. Not sure if its an issue with how the test is written or an issue in Node.js core yet. |
Discussed in Node API meeting on 11 Feb: This issue is still being worked on. In order to reproduce the issue, one can apply the diff in the original comment and see if it's still problematic and causing a crash. We need to determine if it's an issue within core or within how we've written the tests. |
Checked with the latest Node.js LTS releases and the problem seems gone. Bisected through history and identified nodejs/node#39135 fixed the problem. |
Confirmed that when |
Refs: https://github.com/nodejs/node-addon-api/pull/976/files#diff-db9746a1646fe3119716304e4bc4d3fb6a1e8aac5f4ca11da036bb92102dae74R27
Mininal diffs that make
test/callback_scope.js
crashing:Crash backtrace:
Tested Node.js versions:
The text was updated successfully, but these errors were encountered: