Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
deps: update ChakraCore to chakra-core/ChakraCore@59f853017f
Browse files Browse the repository at this point in the history
[1.8>1.9] [MERGE #4611 @obastemur] clang 6.0 support

Merge pull request #4611 from obastemur:clang_6_18

Fixes couple of tiny issues we had with upcoming clang 6.0 release

Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
  • Loading branch information
obastemur authored and chakrabot committed Feb 2, 2018
1 parent 91356f0 commit 27699e1
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion deps/chakrashim/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -322,13 +322,24 @@ if(CLR_CMAKE_PLATFORM_XPLAT)
-Wno-return-type\
-Wno-switch\
-Wno-implicit-function-declaration\
-Wno-int-to-pointer-cast"
-Wno-int-to-pointer-cast\
-Wno-tautological-constant-compare\
-Wno-enum-compare-switch\
-Wno-unknown-warning-option"
)
# notes..
# -Wno-address-of-temporary # vtinfo.h, VirtualTableInfo<T>::RegisterVirtualTable
# -Wno-null-conversion # Check shmemory.cpp and cs.cpp here...
# -Wno-return-type # switch unreachable code
# -Wno-switch # switch values not handled
# -W-enum-compare-switch # throws warning on enum1 == enum2 where both
# enums represent same value but do not share the type. ie. we use both AsmJsType
# and AsmJsRetType interchangably and filter things out by `default:` case.
# -W-tautological-constant-compare throws warning for checks known at compile time.
# Some of those checks are optimized out during compile / lto time, and others
# are platform / compiler dependent.
# -Wno-unknown-warning-option ... well, some of the new switches are not
# recognized by older compilers and they fail. So, put this one and not fail

include(Build/CMakeFeatureDetect.cmake)

Expand Down

0 comments on commit 27699e1

Please sign in to comment.