chakrashim,src: fix build breaks

* Add new shimmed APIs * Remove fail fasts for unimplemented tracing methods * Update startup code for signature changes
nodejs · Apr 18, 2018 · 46966a3 · 46966a3
1 parent 9bd9834
commit 46966a3
Show file tree

Hide file tree

Showing 6 changed files with 5,090 additions and 5,095 deletions.
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -1132,6 +1132,7 @@ class V8_EXPORT Value : public Data {
   bool IsWeakSet() const;
   bool IsPromise() const;
   bool IsProxy() const;
+  bool IsModuleNamespaceObject() const;
 
   V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean(
     Local<Context> context) const;

diff --git a/deps/chakrashim/lib/chakra_shim.js b/deps/chakrashim/lib/chakra_shim.js
@@ -606,6 +606,10 @@
       return compareType(obj, 'SharedArrayBuffer');
     };
 
+    utils.isModuleNamespaceObject = function(obj) {
+      return compareType(obj, 'Module');
+    };
+
     utils.getSymbolKeyFor = function(symbol) {
       return Symbol_keyFor(symbol);
     };

diff --git a/deps/chakrashim/src/jsrtcachedpropertyidref.inc b/deps/chakrashim/src/jsrtcachedpropertyidref.inc
@@ -162,6 +162,7 @@ DEF_IS_TYPE(isWeakSet)
 DEF_IS_TYPE(isSymbolObject)
 DEF_IS_TYPE(isName)
 DEF_IS_TYPE(isSharedArrayBuffer)
+DEF_IS_TYPE(isModuleNamespaceObject)
 
 
 #undef DEF

diff --git a/deps/chakrashim/src/v8v8.cc b/deps/chakrashim/src/v8v8.cc
@@ -226,28 +226,24 @@ namespace platform {
   void SetTracingController(
       v8::Platform* platform,
       v8::platform::tracing::TracingController* tracing_controller) {
-    jsrt::Unimplemented("TracingController");
   }
 }  // namespace platform
 
 namespace platform {
 namespace tracing {
   void TracingController::StopTracing() {
-    jsrt::Unimplemented("TracingController");
   }
 
   void TracingController::StartTracing(TraceConfig*) {
-    jsrt::Unimplemented("TracingController");
   }
 
   void TracingController::Initialize(TraceBuffer*) {
-    jsrt::Unimplemented("TracingController");
   }
 
   const uint8_t* TracingController::GetCategoryGroupEnabled(
       const char* category_group) {
-    jsrt::Unimplemented("TracingController");
-    return nullptr;
+    static uint8_t no = 0;
+    return &no;
   }
 
   uint64_t TracingController::AddTraceEvent(
@@ -257,17 +253,14 @@ namespace tracing {
       const uint64_t* arg_values,
       std::unique_ptr<v8::ConvertableToTraceFormat>* arg_convertables,
       unsigned int flags) {
-    jsrt::Unimplemented("TracingController");
     return 0;
   }
 
   void TracingController::UpdateTraceEventDuration(
       const uint8_t* category_enabled_flag, const char* name, uint64_t handle) {
-    jsrt::Unimplemented("TracingController");
   }
 
   int64_t TracingController::CurrentTimestampMicroseconds() {
-    jsrt::Unimplemented("TracingController");
     return 0;
   }
 

diff --git a/deps/chakrashim/src/v8value.cc b/deps/chakrashim/src/v8value.cc
@@ -180,6 +180,7 @@ IS_TYPE_FUNCTION(IsWeakSet, isWeakSet)
 IS_TYPE_FUNCTION(IsSymbolObject, isSymbolObject)
 IS_TYPE_FUNCTION(IsName, isName)
 IS_TYPE_FUNCTION(IsSharedArrayBuffer, isSharedArrayBuffer)
+IS_TYPE_FUNCTION(IsModuleNamespaceObject, isModuleNamespaceObject)
 
 MaybeLocal<Boolean> Value::ToBoolean(Local<Context> context) const {
   JsValueRef value;