test: update new tests to work with Node-ChakraCore

nodejs · Mar 5, 2018 · 979e36a · 979e36a
1 parent 38d2724
commit 979e36a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/test/parallel/test-buffer-fill.js b/test/parallel/test-buffer-fill.js
@@ -371,7 +371,9 @@ common.expectsError(() => {
   if (common.isChakraEngine) {
     // Skip on ChakraCore due to TypedArray .length JIT bug
     // (see this issue: https://github.com/Microsoft/ChakraCore/issues/2319)
-    throw new RangeError('Index out of range');
+    const err = new RangeError('Index out of range');
+    err.code = 'ERR_INDEX_OUT_OF_RANGE';
+    throw err;
   }
   const buf = new Buffer('w00t');
   Object.defineProperty(buf, 'length', {

diff --git a/test/parallel/test-buffer-writedouble.js b/test/parallel/test-buffer-writedouble.js
@@ -67,10 +67,17 @@ assert.strictEqual(buffer.readDoubleLE(8), -Infinity);
 buffer.writeDoubleBE(NaN, 0);
 buffer.writeDoubleLE(NaN, 8);
 
-assert.ok(buffer.equals(new Uint8Array([
-  0x7F, 0xF8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x7F
-])));
+if (process.jsEngine === 'chakracore') {
+  assert.ok(buffer.equals(new Uint8Array([
+    0xFF, 0xF8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0xFF
+  ])));
+} else {
+  assert.ok(buffer.equals(new Uint8Array([
+    0x7F, 0xF8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x7F
+  ])));
+}
 
 assert.ok(Number.isNaN(buffer.readDoubleBE(0)));
 assert.ok(Number.isNaN(buffer.readDoubleLE(8)));

diff --git a/test/parallel/test-buffer-writefloat.js b/test/parallel/test-buffer-writefloat.js
@@ -51,6 +51,8 @@ assert.strictEqual(buffer.readFloatLE(4), -Infinity);
 buffer.writeFloatBE(NaN, 0);
 buffer.writeFloatLE(NaN, 4);
 assert.ok(buffer.equals(
+  process.jsEngine === 'chakracore' ?
+  new Uint8Array([ 0xFF, 0xC0, 0x00, 0x00, 0x00, 0x00, 0xC0, 0xFF ]) :
   new Uint8Array([ 0x7F, 0xC0, 0x00, 0x00, 0x00, 0x00, 0xC0, 0x7F ])));
 
 assert.ok(Number.isNaN(buffer.readFloatBE(0)));