From 979e36aa59f36b4f2c637424dae8fe92968e0077 Mon Sep 17 00:00:00 2001 From: Jack Horton Date: Mon, 5 Mar 2018 14:44:51 -0800 Subject: [PATCH] test: update new tests to work with Node-ChakraCore --- test/parallel/test-buffer-fill.js | 4 +++- test/parallel/test-buffer-writedouble.js | 15 +++++++++++---- test/parallel/test-buffer-writefloat.js | 2 ++ 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-buffer-fill.js b/test/parallel/test-buffer-fill.js index 6b31c347c8a..8d26f136dbc 100644 --- a/test/parallel/test-buffer-fill.js +++ b/test/parallel/test-buffer-fill.js @@ -371,7 +371,9 @@ common.expectsError(() => { if (common.isChakraEngine) { // Skip on ChakraCore due to TypedArray .length JIT bug // (see this issue: https://github.com/Microsoft/ChakraCore/issues/2319) - throw new RangeError('Index out of range'); + const err = new RangeError('Index out of range'); + err.code = 'ERR_INDEX_OUT_OF_RANGE'; + throw err; } const buf = new Buffer('w00t'); Object.defineProperty(buf, 'length', { diff --git a/test/parallel/test-buffer-writedouble.js b/test/parallel/test-buffer-writedouble.js index 8f56e93f734..a8feffdc833 100644 --- a/test/parallel/test-buffer-writedouble.js +++ b/test/parallel/test-buffer-writedouble.js @@ -67,10 +67,17 @@ assert.strictEqual(buffer.readDoubleLE(8), -Infinity); buffer.writeDoubleBE(NaN, 0); buffer.writeDoubleLE(NaN, 8); -assert.ok(buffer.equals(new Uint8Array([ - 0x7F, 0xF8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x7F -]))); +if (process.jsEngine === 'chakracore') { + assert.ok(buffer.equals(new Uint8Array([ + 0xFF, 0xF8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0xFF + ]))); +} else { + assert.ok(buffer.equals(new Uint8Array([ + 0x7F, 0xF8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x7F + ]))); +} assert.ok(Number.isNaN(buffer.readDoubleBE(0))); assert.ok(Number.isNaN(buffer.readDoubleLE(8))); diff --git a/test/parallel/test-buffer-writefloat.js b/test/parallel/test-buffer-writefloat.js index 865b8838dae..b4599f36cb0 100644 --- a/test/parallel/test-buffer-writefloat.js +++ b/test/parallel/test-buffer-writefloat.js @@ -51,6 +51,8 @@ assert.strictEqual(buffer.readFloatLE(4), -Infinity); buffer.writeFloatBE(NaN, 0); buffer.writeFloatLE(NaN, 4); assert.ok(buffer.equals( + process.jsEngine === 'chakracore' ? + new Uint8Array([ 0xFF, 0xC0, 0x00, 0x00, 0x00, 0x00, 0xC0, 0xFF ]) : new Uint8Array([ 0x7F, 0xC0, 0x00, 0x00, 0x00, 0x00, 0xC0, 0x7F ]))); assert.ok(Number.isNaN(buffer.readFloatBE(0)));