Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: move ChakraCore runtime skips to .status
Browse files Browse the repository at this point in the history
Move all tests that are fully skipped at runtime for the ChakraCore
engine to the .status files as a SKIP entry, so they aren't started
at all.

PR-URL: #436
Refs: #426
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Jack Horton <jahorto@microsoft.com>
  • Loading branch information
jaimecbernardo authored and joaocgreis committed Dec 6, 2017
1 parent 5adda3a commit a008278
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 14 deletions.
4 changes: 4 additions & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ test-v8-version-tag : SKIP
# on v8-option --max-old-space-size
test-windows-failed-heap-allocation : SKIP

# This test is disabled for chakra engine because debugger
# support is not implemented yet.
test-preload : SKIP


[$jsEngine==chakracore && $arch==x64]
# These tests are failing for Node-Chakracore and should eventually be fixed
Expand Down
4 changes: 0 additions & 4 deletions test/parallel/test-preload.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ if (common.isSunOS)

const assert = require('assert');
const childProcess = require('child_process');
if (common.isChakraEngine)
common.skip('This test is disabled for chakra engine because debugger ' +
'support is not implemented yet.');


const nodeBinary = process.argv[0];

Expand Down
8 changes: 7 additions & 1 deletion test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,15 @@ test-inspector-async-hook-setup-at-inspect-brk : SKIP
test-inspector-async-stack-traces-promise-then : SKIP
test-inspector-async-stack-traces-set-interval : SKIP
test-inspector-break-when-eval : SKIP
test-inspector-scriptparsed-context : SKIP
test-inspector-stop-profile-after-done : SKIP

# This test is causing hangs in CI for some reason.
test-inspector-contexts : SKIP

# This test is disabled for chakra engine because the test
# hangs after trying to parse in a new context
test-inspector-scriptparsed-context : SKIP

[$jsEngine==chakracore && $system==linux]
# These tests are failing for Node-Chakracore and should eventually be fixed
test-child-process-pass-fd : SKIP
4 changes: 0 additions & 4 deletions test/sequential/test-inspector-contexts.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,5 @@ async function testBreakpointHit() {
await pausedPromise;
}

if (common.isChakraEngine) {
common.skip('This test is causing hangs in CI for some reason.');
}

common.crashOnUnhandledRejection();
testContextCreatedAndDestroyed().then(testBreakpointHit);
5 changes: 0 additions & 5 deletions test/sequential/test-inspector-scriptparsed-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ common.crashOnUnhandledRejection();
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');

if (common.isChakraEngine) {
common.skip('This test is disabled for chakra engine because the test ' +
'hangs after trying to parse in a new context');
}

const script = `
'use strict';
const assert = require('assert');
Expand Down

0 comments on commit a008278

Please sign in to comment.