Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
lib: removing contents of v8 module under chakracore
Browse files Browse the repository at this point in the history
The v8 module uses functionality which is not supported by chakracore.
Rather than expose stubs which have unexpected behavior, we now do not
expose anything in the v8 module, so dependant modules can do feature
detection.

PR-URL: #491
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
  • Loading branch information
MSLaguana committed Mar 9, 2018
1 parent 17b469b commit bbcf831
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/v8.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@

'use strict';

if (process.jsEngine === 'chakracore') {
return;
}

const { Buffer } = require('buffer');
const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes;
const {
Expand Down
5 changes: 5 additions & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,11 @@ test-fs-readdir-stack-overflow : SKIP
# in a particular way which is true for v8 but not true for charkacore
test-string-decoder-end : SKIP

# These tests use the v8 module which chakracore does not support
test-process-exception-capture-should-abort-on-uncaught-setflagsfromstring : SKIP
test-v8-flag-type-check : SKIP
test-v8-stats : SKIP

[$jsEngine==chakracore && $arch==x64]
# These tests are failing for Node-Chakracore and should eventually be fixed
test-buffer-includes : SKIP
Expand Down

0 comments on commit bbcf831

Please sign in to comment.