Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
lint: fix lint issues from ttd fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jackhorton committed Feb 4, 2018
1 parent ef8cd26 commit d9701a9
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
3 changes: 2 additions & 1 deletion deps/chakrashim/src/inspector/v8-debugger-agent-impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,8 @@ void V8DebuggerAgentImpl::reverse(ErrorString* errorString) {
m_debugger->reverse();
}

void V8DebuggerAgentImpl::writeTTDLog(ErrorString* errorString, const String16& uri) {
void V8DebuggerAgentImpl::writeTTDLog(
ErrorString* errorString, const String16& uri) {
if (!assertPaused(errorString)) return;
m_debugger->writeTTDLog(uri);
}
Expand Down
5 changes: 3 additions & 2 deletions deps/chakrashim/src/inspector/v8-timetravel-agent-impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ bool V8TimeTravelAgentImpl::enabled() {
return jsrt::Inspector::IsTTDebugEnabled();
}

void V8TimeTravelAgentImpl::writeTTDLog(ErrorString* errorString, const String16& uri) {
if(!checkEnabled(errorString)) {
void V8TimeTravelAgentImpl::writeTTDLog(
ErrorString* errorString, const String16& uri) {
if (!checkEnabled(errorString)) {
return;
}

Expand Down
6 changes: 3 additions & 3 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3854,8 +3854,7 @@ static void ParseArgs(int* argc,
// Parse and extract the TT args
} else if (strcmp(arg, "--record") == 0) {
s_doTTRecord = true;
}
else if (strstr(arg, "--tt-debug") == arg) {
} else if (strstr(arg, "--tt-debug") == arg) {
s_doTTRecord = true;
s_doTTEnableDebug = true;
s_ttdSnapInterval = 500;
Expand Down Expand Up @@ -4833,7 +4832,8 @@ inline int Start_TTDReplay(uv_loop_t* event_loop,
Isolate* const isolate = Isolate::NewWithTTDSupport(params,
s_ttoptReplayUriLength,
s_ttoptReplayUri,
false, true, s_doTTEnableDebug,
false, true,
s_doTTEnableDebug,
UINT32_MAX, UINT32_MAX);

if (isolate == nullptr)
Expand Down
2 changes: 1 addition & 1 deletion src/node_buffer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ void Fill(const FunctionCallbackInfo<Value>& args) {
TTD_NATIVE_BUFFER_ACCESS_NOTIFY("Fill Questionable Case");
#endif
return args.GetReturnValue().Set(-1);
}
}

size_t in_there = str_length;
char* ptr = ts_obj_data + start + str_length;
Expand Down

0 comments on commit d9701a9

Please sign in to comment.