Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
chakrashim,lib,test: fix lint errors
Browse files Browse the repository at this point in the history
* Fixed a bunch of issues with whitespace around comments
* Ignored lint issues in `test-util-inspect.js` that seemed to be false
  positives.
  • Loading branch information
kfarnung committed Apr 7, 2018
1 parent 27685b5 commit ed29231
Show file tree
Hide file tree
Showing 9 changed files with 108 additions and 120 deletions.
2 changes: 1 addition & 1 deletion deps/chakrashim/lib/chakra_shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
};

StackFrame.prototype.getTypeName = function() {
//TODO : Fix this
// TODO : Fix this
return this.functionName;
};

Expand Down
4 changes: 2 additions & 2 deletions lib/assert.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const meta = [

const escapeFn = (str) => meta[str.charCodeAt(0)];

const trace_mgr = require('trace_mgr'); //ENABLE_TTD
const trace_mgr = require('trace_mgr'); // ENABLE_TTD

const ERR_DIFF_DEACTIVATED = 0;
const ERR_DIFF_NOT_EQUAL = 1;
Expand Down Expand Up @@ -83,7 +83,7 @@ function innerFail(obj) {
}

function fail(actual, expected, message, operator, stackStartFn) {
trace_mgr.emitTrace('emitOnAssert'); //ENABLE_TTD
trace_mgr.emitTrace('emitOnAssert'); // ENABLE_TTD

const argsLen = arguments.length;

Expand Down
6 changes: 3 additions & 3 deletions lib/console.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const {
isTypedArray, isSet, isMap, isSetIterator, isMapIterator,
} = util.types;
const kCounts = Symbol('counts');
const trace_mgr = require('trace_mgr'); //ENABLE_TTD
const trace_mgr = require('trace_mgr'); // ENABLE_TTD

const {
keys: ObjectKeys,
Expand Down Expand Up @@ -166,15 +166,15 @@ Console.prototype.warn = function warn(...args) {
this._stderrErrorHandler,
this[kGroupIndent]);

trace_mgr.emitTrace('emitOnLogWarn'); //ENABLE_TTD
trace_mgr.emitTrace('emitOnLogWarn'); // ENABLE_TTD
};
Console.prototype.error = function error(...args) {
write(this._ignoreErrors,
this._stderr,
util.format.apply(null, args),
this._stderrErrorHandler,
this[kGroupIndent]);
trace_mgr.emitTrace('emitOnLogError'); //ENABLE_TTD
trace_mgr.emitTrace('emitOnLogError'); // ENABLE_TTD
};

Console.prototype.dir = function dir(object, options) {
Expand Down
5 changes: 2 additions & 3 deletions lib/internal/bootstrap/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
}



setupV8();
setupProcessICUVersions();

Expand Down Expand Up @@ -86,7 +85,7 @@

NativeModule.require('internal/trace_events_async_hooks').setup();
NativeModule.require('internal/inspector_async_hook').setup();
NativeModule.require('trace_mgr'); //ENABLE_TTD;
NativeModule.require('trace_mgr'); // ENABLE_TTD;

_process.setupChannel();
_process.setupRawDebug();
Expand Down Expand Up @@ -455,7 +454,7 @@
if (exceptionHandlerState.captureFn !== null) {
exceptionHandlerState.captureFn(er);
} else if (!process.emit('uncaughtException', er)) {
//ENABLE_TTD
// ENABLE_TTD
NativeModule.require('trace_mgr').onUncaughtExceptionHandler();

// If someone handled it, then great. otherwise, die in C++ land
Expand Down
8 changes: 4 additions & 4 deletions lib/internal/process.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ function setupKillAndExit() {
process.emit('exit', process.exitCode || 0);
}

require('trace_mgr').onExitHandler(process.exitCode || 0); //ENABLE_TTD
require('trace_mgr').onExitHandler(process.exitCode || 0); // ENABLE_TTD
process.reallyExit(process.exitCode || 0);
};

Expand Down Expand Up @@ -214,10 +214,10 @@ function setupSignalHandlers() {
wrap.unref();

if (type === 'SIGINT' && global.enabledDiagnosticsTrace) {
//TODO: this is probably a little over complicated
// TODO: this is probably a little over complicated
// -- should unify this and ttdSigIntHandler setup below
// -- ttdSigIntHandler will emit event after it runs
wrap.onsignal = function() { }; //ENABLE_TTD
wrap.onsignal = function() { }; // ENABLE_TTD
} else {
wrap.onsignal = process.emit.bind(process, type, type);
}
Expand All @@ -240,7 +240,7 @@ function setupSignalHandlers() {
}
});

//ENABLE_TTD
// ENABLE_TTD
if (global.enabledDiagnosticsTrace) {
(function() {
const type = 'SIGINT';
Expand Down
Loading

0 comments on commit ed29231

Please sign in to comment.