Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Cache napi_env per runtime #353

Open
kfarnung opened this issue Aug 1, 2017 · 0 comments
Open

Cache napi_env per runtime #353

kfarnung opened this issue Aug 1, 2017 · 0 comments
Assignees

Comments

@kfarnung
Copy link
Contributor

kfarnung commented Aug 1, 2017

Currently the JSRT implementation for N-API uses a new instance of napi_env per module load. Recently a change went into the upstream implementation to cache the pointer inside of the isolate as a private global property (nodejs/node#14217) and introduced a new test which fails on node-chakracore. We should investigate whether we can do the same optimization and re-enable the test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants