Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not get CLTVersion #1849

Closed
msageha opened this issue Aug 2, 2019 · 5 comments
Closed

Could not get CLTVersion #1849

msageha opened this issue Aug 2, 2019 · 5 comments

Comments

@msageha
Copy link

msageha commented Aug 2, 2019

if CLT version is over 10.*, it could not get the version.
version = re.match(r'(\d+\.\d+\.?\d*)', version).groups()

and now latest CLT version is 10.14.

https://developer.apple.com/download/more/?=command%20line%20tools

https://github.com/nodejs/node-gyp/blob/872ee89a8541264ee2d96e162d410f478bba7815/gyp/pylib/gyp/xcode_emulation.py

@rvagg
Copy link
Member

rvagg commented Aug 2, 2019

I don't think that's your problem @tibbers622:

$ python
Python 2.7.16 (default, Mar 22 2019, 15:22:50)
[GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.11.45.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import re
>>> version = "10.14"
>>> re.match(r'(\d+\.\d+\.?\d*)', version).groups()[0]
'10.14'

Can you give us some error output for a problem you're experiencing with this code? The \d+ should match both 10 and 14 just fine.

@cclauss
Copy link
Contributor

cclauss commented Aug 2, 2019

Fascinating because GYP3's code incorrectly returns 10.1

https://github.com/refack/GYP3/blob/master/gyp/xcode_emulation.py#L1407

@cclauss
Copy link
Contributor

cclauss commented Sep 30, 2019

I believe that #1890 fixed this. Please reverify.

@cclauss
Copy link
Contributor

cclauss commented Oct 2, 2019

@tibbers622 Should this issue be closed?

@cclauss
Copy link
Contributor

cclauss commented Oct 24, 2019

Closing in favor of #1927. @tibbers622 If this has not been resolved, please jump in on #1927.

@cclauss cclauss closed this as completed Oct 24, 2019
@cclauss cclauss added the gyp: No Xcode or CLT version detected! See: macOS_Catalina.md label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants