From 07ba2875aef02e8608cce4419bd7d6c840628781 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 28 Jun 2021 09:29:56 -0700 Subject: [PATCH] doc: remove instructions for unsupported Node.js versions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove special V8 maintenance instructions for versions of Node.js prior to 9.0.0. Perform other minor edits in nearby text. PR-URL: https://github.com/nodejs/node/pull/39185 Reviewed-By: Richard Lau Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Gerhard Stöbich --- doc/guides/maintaining-V8.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/doc/guides/maintaining-V8.md b/doc/guides/maintaining-V8.md index 59887a19f940bf..6234b29bc2b225 100644 --- a/doc/guides/maintaining-V8.md +++ b/doc/guides/maintaining-V8.md @@ -213,17 +213,12 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change. * Checkout a branch off the appropriate *vY.x-staging* branch (e.g. *v6.x-staging* to fix an issue in V8 5.1). * Cherry-pick the commit(s) from the V8 repository. - * On Node.js < 9.0.0: Increase the patch level version in `v8-version.h`. - This will not cause any problems with versioning because V8 will not - publish other patches for this branch, so Node.js can effectively bump the - patch version. - * On Node.js >= 9.0.0: Increase the `v8_embedder_string` number in - `common.gypi`. + * Increase the `v8_embedder_string` number in `common.gypi`. * In some cases the patch may require extra effort to merge in case V8 has - changed substantially. For important issues we may be able to lean on the + changed substantially. For important issues, we may be able to lean on the V8 team to get help with reimplementing the patch. - * Open a cherry-pick PR on `nodejs/node` targeting the *vY.x-staging* branch - and notify the `@nodejs/v8` team. + * Open a cherry-pick pull request on `nodejs/node` targeting the + *vY.x-staging* branch and notify the `@nodejs/v8` team. * Run the Node.js [V8 CI][] in addition to the [Node.js CI][]. The CI uses the `test-v8` target in the `Makefile`, which uses `tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to